Conversation
D4 removed event.points_value, but this club-event fixture still set it. Dead data rather than a failure — the fixture is a plain object handed to a mock, not typed against the schema — but it reads as though club events still carry points, which is exactly the impression D4 set out to remove. Verified: typecheck, 426 tests, lint --max-warnings 0, build.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_799e0b3a-1552-4f7b-9626-a23018810da2) |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Visit the preview URL for this PR (updated for commit 2a7fe0f): https://hacklytics2027--pr-332-i7h5vh7s.web.app (expires Sun, 16 Aug 2026 03:17:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c48ba34db61581e25fe2978355160b5eefe0e83f |
|
| Filename | Overview |
|---|---|
| packages/api/src/.internal-tests/qr-checkin.test.ts | Removes an obsolete, unused property from a plain mock event fixture without changing tested behavior. |
Reviews (1): Last reviewed commit: "chore(tests): drop the last points fixtu..." | Re-trigger Greptile
1 participant
Brings
devup to date withmainafter #330.The stack (#316, #318, #320, #323, #325) plus the follow-ups (#327, #328, #330) all landed directly on
main, sodevneeds the sync — otherwise anyone working off it is missing the membership decoupling, the judging fixes and the check-in fix that makes submission possible at all.No new code here; this is a merge of commits already reviewed and merged on
main.Note
Low Risk
Merge-only sync with a trivial test fixture tweak; no runtime behavior changes in this diff.
Overview
This PR merges already-reviewed
maincommits intodevso branches stay aligned after work landed onmain(#330 and related stacks). No new product logic appears in the diff.The only visible change in the provided diff is in
qr-checkin.test.ts: theclubEventtest helper dropspointsValue: 10, matching removal of event points from the API/schema elsewhere onmain(membership decoupling). Test fixtures no longer model a field the product no longer uses.Reviewed by Cursor Bugbot for commit 2a7fe0f. Bugbot is set up for automated code reviews on this repo. Configure here.